The teacher angle definitely gives you increased access and social proof but, like everything else about the scene, isn't what it used to be, say, even 5-10 years ago. Enough "teachers" are transparently and sloppily hitting on the chicks that the word is pretty much out--especially now.
A good data point for this is
Alex da Silva, once one of the most famous teachers in the country (and a guy who was quite good at pulling decent talent from his classes), getting thrown in jail for like a decade when several chicks alleged that he'd raped them. This dude was world champion several times and was even the choreographer for a national dance TV show.
The "creepy" factor from the teacher angle, in other words, is at an all-time high as a result of these kinds of cases and the proliferation of guys claiming "teacher" status. They're everywhere. Miscellaneous good dancers have shitty business cards printed up, dance with newbie, and hand them a card for a free "lesson." These guys, who are numerous, are diluting (and probably have already killed) the legit teacher angle. Add to this that most of the chicks I ever saw top teachers pulling were the horny cougars (which Courage Reborn correctly ID'd as a major demographic in the scene above).
Finally, keep in mind that getting good enough at salsa that you can teach in a competitive market like LA or NY is a huge time investment. It may be worth it if you're already quite good at dancing, and love it independently of chicks, but there are better ways to get access or social proof.
The bottom line is that salsa, while not dead, is an over-mined resource in 2013. Dudes have been riding that shit hard for over a decade, and are still piling into the clown car, while the chicks have scattered elsewhere. It may restore itself in the coming years, but don't say I didn't warn you.